Class Scope was being returned in Memory Snapshot

[tomlm]

As was Settings scope.

Since these are immutable values I don't think it makes sense for them to be sent as part of the memory snapshot, as that would push settings secrets into transcript logs as well as attempt to serialize objects that aren't designed to be serialized.

• changed GetSnapshotMemory() to not take snapshot of readonly memory
• Made settings an explicit implemented memoryscope. Old code was "filling" the settings in external location, now it's internal to SettingsMemoryScope

[coveralls]

Pull Request Test Coverage Report for Build 82841

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 12 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+0.03%) to 78.597%

---

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogManager.cs	1	70.64%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogSet.cs	1	90.48%
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs	1	76.24%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs	1	57.23%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs	2	50.0%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs	2	86.09%
/libraries/Microsoft.Bot.Builder.Dialogs/Memory/Scopes/MemoryScope.cs	4	85.71%

Totals
Change from base Build 82810:	0.03%
Covered Lines:	5402
Relevant Lines:	6873

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 82841

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 11 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-1.3%) to 77.275%

---

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogManager.cs	3	67.07%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogSet.cs	3	87.32%
/libraries/Microsoft.Bot.Builder.Dialogs/Memory/Scopes/MemoryScope.cs	5	88.37%

Totals
Change from base Build 82810:	-1.3%
Covered Lines:	7583
Relevant Lines:	9813

---

💛 - Coveralls

[fuselabs]

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3