Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked InputDialogs core processing flow #2735

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

Stevenic
Copy link
Contributor

  • Removed SetProperty hack to clear dialog stack.
  • Corrected logic for what gets evaluated for users input.
  • Tweak to the way interruptions are handled.
  • Updated unit tests.

- Removed SetProperty hack to clear dialog stack.
- Corrected logic for what gets evaluated for users input.
- Tweak to the way interruptions are handled.
- Updated unit tests.
@coveralls
Copy link
Collaborator

coveralls commented Oct 15, 2019

Pull Request Test Coverage Report for Build 83394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.4%) to 77.274%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs 1 75.14%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 57.23%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Memory/DialogStateManager.cs 2 65.81%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs 2 86.09%
Totals Coverage Status
Change from base Build 83280: -1.4%
Covered Lines: 7603
Relevant Lines: 9839

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit c042fa7 into master Oct 15, 2019
@tomlm tomlm deleted the stevenic/input-dialog-fixes branch October 15, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants