Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teams] Hackathon feedback #2740

Merged
merged 6 commits into from
Oct 15, 2019
Merged

[Teams] Hackathon feedback #2740

merged 6 commits into from
Oct 15, 2019

Conversation

EricDahlvang
Copy link
Member

@EricDahlvang EricDahlvang commented Oct 15, 2019 •
edited

Fixes:
#2737
and
#2718

• Remove the tenant filtering middleware from the product, and add to samples
-Removed TeamsTenantFilteringMiddleware from the product and added it to Roster bot as an example.

• Bot message preview edit/send return value should be bad request if malformed
-now returning BadRequest

• File consent should be bad request if malformed
-now returning BadRequest

• OnTeamsMessagingExtensionFetchTaskAsync should take a MessagingExtensionAction and not MessagingExtensionQuery
-Changed parameter type

• In TeamACtivityHandler we should check whether there is an InvokeResponse activity on the turnstate and if there is don’t overwrite it.
- added check of TurnState for existing InvokeResponse

• OnSigninVerifyStateAsync should be void (create invoke response internally, if not present in turnstate)
- Changed return type to void, added test

• Change TeamsActivityHandler's task/fetch and task/submit return types to TaskModuleResponse

Eric Dahlvang added 3 commits October 15, 2019 10:18
Remove TeamsTenantFilteringMiddleware (add it to Roster sample).
bebed8c
Change OnTeamsMessagingExtensionFetchTaskAsync to take MessagingExten…
9a0b07f 
…sionAction and not MessagingExtensionQuery.

Change bad preview edit/send and bad file consent to return BadRequest.
Check whether there is an InvokeResponse activity on the turnstate an…
36583d9 
…d if there is don’t overwrite it. OnTeamsSigninVerifyStateAsync returns void (create InvokeResponse internally)
@coveralls
Copy link
Collaborator

coveralls commented Oct 15, 2019 •
edited

Pull Request Test Coverage Report for Build 83559

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.06%) to 78.831%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs 1 75.14%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs 1 57.23%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs 2 50.0%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs 2 86.09%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs 12 83.16%
Totals Coverage Status
Change from base Build 83506: 0.06%
Covered Lines: 5422
Relevant Lines: 6878
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

Remove custom BadRequestArgumentException and throw InvalidOperationE…
eea25ab 
…xception for OnTeamsFileConsentAsync and OnTeamsMessagingExtensionSubmitActionDispatchAsync
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@EricDahlvang EricDahlvang added 4.6 October 31, 2019 Release teams labels Oct 15, 2019
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

johnataylor
johnataylor approved these changes Oct 15, 2019
View reviewed changes
libraries/Microsoft.Bot.Builder/Teams/TeamsActivityHandler.cs

public InvokeResponse CreateInvokeResponse()
{
return new InvokeResponse { Status = (int)StatusCode };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we could add message text in here... not blocking this PR as this is all internal

@johnataylor johnataylor merged commit d6b6ca6 into master Oct 15, 2019
@johnataylor johnataylor deleted the eric/teamsHackFeedback branch October 15, 2019 22:18
@EricDahlvang EricDahlvang mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
4.6 October 31, 2019 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricDahlvang @coveralls @fuselabs @johnataylor