-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Twilio Adapter] Apply feedback to have adapter ready for release #2769
Conversation
Appied feedback from issue #2542 Refactored adapter to receive wrapper, and wrapper to receive options Adapter unit tests to reflect Changed files payload in unit tests
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3 |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just requested an additional change to replace a null return with an exception in line with the updated advice for the other adapters. Once this is done I think we should be good to go with this. Thanks.
libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ceciliaavila This is looking good, but looks like a couple of stylecop rules are causing the build to fail. Can you fix and request a review once the build passes and I can approve / merge? Thanks.
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3 |
Description
Applied other adapter's feedback in order to even them all and getting them ready for release.
Details