Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions in Debugger support #2781

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Fix regressions in Debugger support #2781

merged 1 commit into from
Oct 19, 2019

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Oct 19, 2019

  • Debugger requires camelcase serialization when communicating with vscode debugger
  • VSCode sends different case drive letter then IIS has.
    ** Added support to only use file name for resources, (.dialog, .lg, etc.)
    ** made path case insensitive on windows platform.

Debugger requires camelcase serialization when communicating with vsc…
3481083 
…ode debugger

VSCode sends different case drive letter then IIS has.  Added support to only use file name for resources, (.dialog, .lg, etc.) and be case insensitive on windows platform.
@coveralls
Copy link
Collaborator

coveralls commented Oct 19, 2019 •
edited

Pull Request Test Coverage Report for Build 84462

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 78.611%
Totals Coverage Status
Change from base Build 84459: 0.9%
Covered Lines: 12000
Relevant Lines: 15265
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

carlosscastro
carlosscastro approved these changes Oct 19, 2019
View reviewed changes
libraries/Microsoft.Bot.Builder.Dialogs.Debugging/DebuggerSourceMap.cs
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
// we want to be case insensitive on windows
one = one.ToLower();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can people use different cultures for paths? If yes, ToLowerInvariant() is safer for cross culture strings in this case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same on line 170

@tomlm tomlm merged commit 5102b97 into master Oct 19, 2019
@tomlm tomlm deleted the tomlm/fixDebugger branch October 19, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomlm @coveralls @fuselabs @carlosscastro