Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkillHostAdapter Constructor updates #2793

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Oct 21, 2019

Removed IBot from the BotFrameworkSkillHostAdapter/SkillHostAdapter constructos (and the related property) and updated the code to use the IBot instance passed in the BotFrameworkHttpSkillsServer.ProcessAsync()

Updated unit tests project to use XUnit.

Relates to #2774

…onstructos (and the related property) and updated the code to use the IBot instance passed in the BotFrameworkHttpSkillsServer.ProcessAsync()

Updated unit tests project to use XUnit.
@gabog gabog requested a review from tomlm October 21, 2019 20:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 84619

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 76.014%

Totals Coverage Status
Change from base Build 84533: -1.4%
Covered Lines: 7926
Relevant Lines: 10427

💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

@tomlm
Copy link
Contributor

tomlm commented Oct 21, 2019

    /// <param name="bot">bot callback to use in the turn context.</param>

remove


Refers to: libraries/Microsoft.Bot.Builder.Skills/Adapters/BotFrameworkSkillHostAdapter.cs:68 in 90899d7. [](commit_id = 90899d7, deletion_comment = False)

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 6627738 into master Oct 21, 2019
@tomlm tomlm deleted the gabog/SkillHostAdapterConstructorUpdates branch October 21, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants