Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DCR [Adaptive] - Add disabled expression to all Actions #3181

Merged
merged 5 commits into from
Jan 6, 2020
Merged

Implement DCR [Adaptive] - Add disabled expression to all Actions #3181

merged 5 commits into from
Jan 6, 2020

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Dec 20, 2019

DCR #3139

  • add disabled expression property to all Actions and Input. If a expression is defined and it returns true then the action will immediately endDialog (aka, not be executed).

@tomlm tomlm added adaptive R8 Release 8 - March 16th, 2020 labels Dec 20, 2019
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2019 •
edited

Pull Request Test Coverage Report for Build 97690

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 366 unchanged lines in 29 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.231%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EditActions.cs 4 82.14%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/BreakLoop.cs 5 66.67%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ContinueLoop.cs 5 66.67%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EndTurn.cs 5 54.55%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEach.cs 5 83.33%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ReplaceDialog.cs 5 60.0%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/TraceActivity.cs 5 77.27%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/BeginDialog.cs 6 70.0%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/DeleteProperties.cs 6 58.82%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperties.cs 6 68.42%
Totals Coverage Status
Change from base Build 97633: -0.1%
Covered Lines: 14199
Relevant Lines: 18150
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@tomlm tomlm changed the title Implement DCR [Adaptive] - Providing a "disabled" indicator in Actions Implement DCR [Adaptive] - Add disabled expression to all Actions Dec 24, 2019
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@tomlm tomlm merged commit 307c0fa into master Jan 6, 2020
This was referenced Jan 6, 2020
Closed
Closed
Closed
@tomlm tomlm deleted the tomlm/disabled branch January 6, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomlm @coveralls @fuselabs @carlosscastro