Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix include activity and enum camelcase #3229

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Jan 7, 2020

fix #3220
fix #3228

  • rename IncludeActivity => activityProcessed with default value of true, and dialog actions to always set TurnPath.ACTIVITYPROCESSED when passing focus to another dialog
  • fixed unit tests around ActivityProcessed behavior
  • added appropriate attributes and updated .schema and dialog files for enums

Tom Laird-McConnell added 3 commits January 6, 2020 14:19
@tomlm tomlm added adaptive R8 Release 8 - March 16th, 2020 bug Indicates an unexpected problem or an unintended behavior. labels Jan 7, 2020
@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2020

Pull Request Test Coverage Report for Build 98923

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.003%) to 78.1%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/SequenceContext.cs 1 52.78%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/TriggerConditions/OnIntent.cs 1 93.88%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/BaseInvokeDialog.cs 3 87.5%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Input/NumberInput.cs 6 81.25%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EditArray.cs 15 73.44%
Totals Coverage Status
Change from base Build 98911: 0.003%
Covered Lines: 14283
Relevant Lines: 18288

💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Jan 7, 2020

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enums are not camelcased [Adaptive] IncludeActivity property does not work
4 participants