Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat '@{' an error instead of text in LG #3269

Merged
merged 8 commits into from
Feb 12, 2020
Merged

Treat '@{' an error instead of text in LG #3269

merged 8 commits into from
Feb 12, 2020

Conversation

Danieladu
Copy link
Collaborator

close: #3265

@coveralls
Copy link
Collaborator

coveralls commented Jan 19, 2020

Pull Request Test Coverage Report for Build 105564

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 77.995%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.LanguageGeneration/LGErrors.cs 3 55.56%
Totals Coverage Status
Change from base Build 105552: -1.4%
Covered Lines: 17701
Relevant Lines: 22695

💛 - Coveralls

@tomlm tomlm added the WIP label Jan 21, 2020
@johnataylor
Copy link
Member

No update on this - closing for now. Please reopen when you want someone's feedback. In the meantime you can continue this work on your branch.

@Danieladu Danieladu reopened this Feb 6, 2020
@Danieladu Danieladu marked this pull request as ready for review February 6, 2020 03:40
@Danieladu Danieladu removed the WIP label Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 6, 2020
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DCR] Treat '@{' an error instead of text in LG
5 participants