Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .Net Core sdk 3.0.x to 3.1.x. #3304

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

BruceHaley
Copy link
Contributor

No description provided.

Copy link
Contributor

@garypretty garypretty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it, my only worry about this PR is that we might break other people’s builds until everyone has the 3.1 changes. Do we not need to make 3.1 additive in the build pipeline (as well as 3.0) so that both SDKs are available? It looks like your PR replaces 3.0 with 3.1. In the GUI based pipelines we just added an additional “Use .Net Core 3.1” task.

@garypretty
Copy link
Contributor

Looking at it, my only worry about this PR is that we might break other people’s builds until everyone has the 3.1 changes. Do we not need to make 3.1 additive in the build pipeline (as well as 3.0) so that both SDKs are available? It looks like your PR replaces 3.0 with 3.1. In the GUI based pipelines we just added an additional “Use .Net Core 3.1” task.

Maybe not....I guess having just 3.1 might work. I will watch the automated builds. 👍

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@BruceHaley
Copy link
Contributor Author

Builds are all passing without v 3.0.x.

@BruceHaley BruceHaley dismissed garypretty’s stale review January 28, 2020 20:38

Builds are all passing without v 3.0.x.

@BruceHaley BruceHaley merged commit 50ad493 into master Jan 28, 2020
@BruceHaley BruceHaley deleted the v-bruhal/coreupdate branch February 14, 2020 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants