-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerant null in LG context #3329
Conversation
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3 |
libraries/Microsoft.Bot.Builder.LanguageGeneration/Evaluator.cs
Outdated
Show resolved
Hide resolved
libraries/Microsoft.Bot.Builder.LanguageGeneration/Evaluator.cs
Outdated
Show resolved
Hide resolved
will this be a public option instead of a private one? |
This PR's intention is to make not throw exception as default. We will explore whether make it configurable with something like "strict=true", which is out of scope of this one, and will be taken into considerations with other possible configurable behavior together. |
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3 |
libraries/Microsoft.Bot.Builder.LanguageGeneration/Evaluator.cs
Outdated
Show resolved
Hide resolved
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3 |
close: #3326
Original issue:
Today if user.name is null, it will result an exception, we should change this to "null" (we can optimize the result later) so that user won't be interrupted by exceptions.
Expected result: