Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adaptive] Updates to description text for inputs #3340

Merged
merged 3 commits into from
Feb 5, 2020
Merged

[Adaptive] Updates to description text for inputs #3340

merged 3 commits into from
Feb 5, 2020

Conversation

vishwacsena
Copy link
Contributor

Fixes #2934

Vishwac Sena Kannan and others added 2 commits February 4, 2020 16:29
@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2020 •
edited

Pull Request Test Coverage Report for Build 103954

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1282 unchanged lines in 160 files lost coverage.
  • Overall coverage decreased (-1.5%) to 78.04%
Files with Coverage Reduction New Missed Lines %
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs 1 86.67%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs 1 71.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs 1 96.36%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs 1 96.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs 1 96.35%
/libraries/Microsoft.Bot.Builder/BotStateSet.cs 1 85.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/DebugSupport.cs 1 75.0%
/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs 1 46.15%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/ComponentRegistration.cs 1 71.43%
/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Resources/ResourceExplorer.cs 1 96.3%
Totals Coverage Status
Change from base Build 103712: -1.5%
Covered Lines: 21184
Relevant Lines: 27145
💛 - Coveralls

@fuselabs
Copy link
Collaborator

fuselabs commented Feb 5, 2020

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

chrimc62
chrimc62 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fuselabs
Copy link
Collaborator

fuselabs commented Feb 5, 2020

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@vishwacsena vishwacsena merged commit 8f80ac5 into master Feb 5, 2020
@vishwacsena vishwacsena deleted the vishwac/2934 branch February 5, 2020 19:04
This was referenced Feb 5, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value in Prompts
4 participants
@vishwacsena @coveralls @fuselabs @chrimc62