Merge temporary assembly Expressions.Properties into Expressions #3365
Conversation
tomlm
commented
Feb 8, 2020
tomlm
commented
- Switch to string Interpolation instead of LGFile
- Cleaned up semantics around switchcondition (it's not a stringExpression) and case (it's always a constant).
- Moved Evaluate() from extension method to LGFile
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3 |
…ays to make it consistent on build servers
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3 |
| @@ -38,7 +38,7 @@ public SwitchCondition([CallerFilePath] string callerPath = "", [CallerLineNumbe | |||
| /// Value Expression against memory. This value expression will be combined with value expression in case statements to make a bool expression. | |||
| /// </value> | |||
| [JsonProperty("condition")] | |||
| public ValueExpression Condition { get; set; } | |||
| public Expression Condition { get; set; } | |||
There was a problem hiding this comment.
Expression [](start = 15, length = 10)
You want to require an expression?
There was a problem hiding this comment.
Yes, it doesn't make any sense to say
switch (13)
or
switch("Hello")
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SwitchCondition.cs
Show resolved
Hide resolved
...ries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.SwitchCondition.schema
Show resolved
Hide resolved
| "luis": { | ||
| "sandwich_en-us_lu": "236ff454-e019-4ab3-ad5f-0ae22d65ad33" | ||
| } | ||
| } |
There was a problem hiding this comment.
Why do you delete these? What is our policy around these? We need at least one checked-in for the mock stuff to work, but we also need people to be able to update the mock. Whose settings win?
