Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCR 3200 QnAMakerRecognizer improvements. #3376

Merged
merged 20 commits into from
Feb 18, 2020
Merged

DCR 3200 QnAMakerRecognizer improvements. #3376

merged 20 commits into from
Feb 18, 2020

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Feb 11, 2020

DCR #3200

  • Cleaned up CrossTrainedRecgonizerSet to collect recgonizer result by id instead of top intent name.
  • added expressions to better configure QnAMakerRecognizer

* Cleaned up CrossTrainedRecgonizerSet to collect recgonizer result b…
b07b2ce 
…y id instead of top intent name.

* added expressions to better configure QnAMakerRecognizer
@tomlm tomlm added DCR P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020 labels Feb 11, 2020
@coveralls
Copy link
Collaborator

coveralls commented Feb 11, 2020 •
edited

Pull Request Test Coverage Report for Build 106721

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1339 unchanged lines in 171 files lost coverage.
  • Overall coverage decreased (-1.4%) to 77.991%
Files with Coverage Reduction New Missed Lines %
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs 1 86.67%
/libraries/AdaptiveExpressions/ExpressionProperties/BoolExpression.cs 1 95.45%
/libraries/AdaptiveExpressions/ExpressionProperties/EnumExpression.cs 1 96.88%
/libraries/AdaptiveExpressions/ExpressionProperties/IntExpression.cs 1 95.45%
/libraries/AdaptiveExpressions/ExpressionProperties/NumberExpression.cs 1 95.45%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs 1 71.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs 1 96.36%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs 1 96.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs 1 96.35%
/libraries/Microsoft.Bot.Builder/BotStateSet.cs 1 85.0%
Totals Coverage Status
Change from base Build 106697: -1.4%
Covered Lines: 21120
Relevant Lines: 27080
💛 - Coveralls

Tom Laird-McConnell added 11 commits February 11, 2020 17:03
Add Expression assignment to ExpressionProperties
9018cef 
(This enables Expression.Lambda((data) => result)
refactored ChooseIntent to have candidates array on the root recogniz…
df0e96c 
…er result with the intent, id, score and result.
* Fix QnAMAkerRecognizer to return none if no text instead of exception
b73536a 
* Fix RecognizerSet to merge extended properties
* update OnActivity and OnChooseIntent to be against the event instead of the turn.recognized
* Fix EmitEvent to emit the event to the parent dialog
0c17b7d 
* Add unit test which verifies that ChooseIntent can Emit an IntentRecognized from the candidates and drive conversation forward.
Move ProcesEntities into general turn mappping section
c30006f
* fix action scope for applying changes
fff958d 
* cleanup unused members of sequenceContext
* update OnChooseIntent to show interruption works correctly
Add Debuger back into testbot
50e7d80
plumb debugport through
4074774
add trace as well as console
9f5d58f
Merge branch 'master' into tomlm/cleanupQnA
d421cef
add configureawait()
dcfe73b
@tomlm tomlm added the WIP label Feb 14, 2020
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Tom Laird-McConnell added 5 commits February 14, 2020 12:37
add unit test around allowinterruption
7c0bc2a
* make sure that processEvent properly pulls activity from dialogEven…
cde717c 
…t instead of directly from the turncontext.

* add unit tests for EmitEvent with an activityReceived
* change Reconigzer to take in Activity always.
* fix cloning of turncontext to include turnstate
e4cfd11
fix OnQnAMatch trigger registration
1235f31 
add qnaId and updated .schema files
Merge branch 'master' into tomlm/cleanupQnA
9d701e1
@microsoft microsoft deleted a comment from fuselabs Feb 18, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 18, 2020
@microsoft microsoft deleted a comment from fuselabs Feb 18, 2020
vishwacsena
vishwacsena approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@vishwacsena vishwacsena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all functionality using both code based and declarative sample bot. Verified basic qna integration, qna integration with disambiguation as well as qna integration with multi-turn support.

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@tomlm tomlm merged commit d5cb749 into master Feb 18, 2020
@tomlm tomlm deleted the tomlm/cleanupQnA branch February 18, 2020 21:57
This was referenced Feb 18, 2020
Closed
Closed
Closed
@tomlm tomlm added 4.2 December 15, 2018 Release and removed WIP labels Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwacsena vishwacsena vishwacsena approved these changes

@carlosscastro carlosscastro carlosscastro approved these changes

Assignees
No one assigned
Labels
4.2 December 15, 2018 Release P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomlm @coveralls @fuselabs @vishwacsena @carlosscastro