Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

${} instead of @{} as bounding syntax. #3381

Merged
merged 10 commits into from
Feb 16, 2020
Merged

${} instead of @{} as bounding syntax. #3381

merged 10 commits into from
Feb 16, 2020

Conversation

Danieladu
Copy link
Collaborator

change @{} to ${}
ref: #3249

@Danieladu Danieladu added LG P0 Must Fix. Release-blocker labels Feb 12, 2020
@coveralls
Copy link
Collaborator

coveralls commented Feb 12, 2020 •
edited

Pull Request Test Coverage Report for Build 106316

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 77.821%
Totals Coverage Status
Change from base Build 106151: -1.6%
Covered Lines: 21003
Relevant Lines: 26989
💛 - Coveralls

@Danieladu Danieladu marked this pull request as ready for review February 12, 2020 07:49
@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@xieofxie
Copy link
Contributor

when will this be shipped?

@Danieladu
Copy link
Collaborator Author

Danieladu commented Feb 12, 2020 •
edited

when will this be shipped?

The sooner the better. With the lower cost.

@xieofxie
Copy link
Contributor

when will this be shipped?

The sooner the better. With the lower cost.

Such philosopher when WFH! LOL

@chrimc62
Copy link
Contributor 

       var result = ExpressionRecognizeRegex.Replace(stringContent, evalutor);

Should be evaluator.

Refers to: libraries/Microsoft.Bot.Builder.LanguageGeneration/Evaluator.cs:486 in d5667d2. [](commit_id = d5667d2, deletion_comment = False)

chrimc62
chrimc62 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@Danieladu Danieladu merged commit ea87e8c into master Feb 16, 2020
@Danieladu Danieladu deleted the hond/new-expression-format branch February 16, 2020 08:58
This was referenced Feb 16, 2020
Closed
Closed
@tomlm tomlm mentioned this pull request Feb 16, 2020
Closed
@ryanisgrig ryanisgrig mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@chrimc62 chrimc62 chrimc62 approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Danieladu @coveralls @fuselabs @xieofxie @chrimc62 @boydc2014