[Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients #3409

stevengum · 2020-02-19T19:28:59Z

Fixes: #3386
Addresses microsoft/botframework-sdk#5751 in C#

PR will address doing proactive-messaging for non-channel recipients and caching keys for BotFrameworkAdapter.

PR is in draft because the former item is addressed by current commits.

commit 1385c8f

add BotFrameworkAdapter.ContinueSkillConversationAsync
add SkillConversationReference
make cancellationToken optional in CreateConnectorClientAsync

* add SkillConversationReference * make cancellationToken optional in CreateConnectorClientAsync

coveralls · 2020-02-19T20:45:30Z

Pull Request Test Coverage Report for Build 107715

0 of 0 changed or added relevant lines in 0 files are covered.
364 unchanged lines in 19 files lost coverage.
Overall coverage increased (+1.5%) to 79.525%

Files with Coverage Reduction	New Missed Lines	%
/libraries/AdaptiveExpressions/Converters/StringExpressionConverter.cs	1	70.0%
/libraries/AdaptiveExpressions/LRUCache.cs	1	82.93%
/libraries/AdaptiveExpressions/TriggerTrees/Trigger.cs	1	85.09%
/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs	1	86.03%
/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs	1	56.4%
/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs	1	78.89%
/libraries/Microsoft.Bot.Builder.LanguageGeneration/StaticChecker.cs	1	98.29%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs	2	75.0%
/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs	2	86.09%
/libraries/Microsoft.Bot.Builder.LanguageGeneration/LGErrors.cs	3	70.0%

Totals
Change from base Build 106816:	1.5%
Covered Lines:	10887
Relevant Lines:	13690

💛 - Coveralls

fuselabs · 2020-02-19T20:46:06Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

* audience and ConversationReference is required * delete SkillConversationReference class

fuselabs · 2020-02-19T22:59:57Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

fuselabs · 2020-02-21T02:07:24Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

* needed to create the correct keys for AppCredentials cache * cache OAuthScope on TurnState

fuselabs · 2020-02-21T07:26:27Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

fuselabs · 2020-02-21T17:41:27Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

stevengum · 2020-02-21T19:46:02Z

This PR might resolve #3418, the start of this work has been performed in 52bb8dd

* new test cleanup

fuselabs · 2020-02-21T22:48:25Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs

add BotFrameworkAdapter.ContinueSkillConversationAsync

1385c8f

* add SkillConversationReference * make cancellationToken optional in CreateConnectorClientAsync

stevengum added the Skills label Feb 19, 2020

stevengum requested review from johnataylor, gabog and carlosscastro February 19, 2020 19:29

stevengum self-assigned this Feb 19, 2020

use audience in CreateConnectorClientAsync

eb2614e

stevengum mentioned this pull request Feb 19, 2020

Audience and ConversationReference is required for Proactive Messaging non-channel recipients microsoft/botframework-sdk#5751

Closed

10 tasks

update ContinueSkillConversationAsync

ec46cac

* audience and ConversationReference is required * delete SkillConversationReference class

cache OAuthScope on TurnState

a9c8ce3

get OAuthScope in ProcessActivityAsync

52bb8dd

* needed to create the correct keys for AppCredentials cache * cache OAuthScope on TurnState

add ProcessActivityAsync test for skill scenario

e24c5f7

stevengum mentioned this pull request Feb 21, 2020

Move BotIdentityKey to BotAdapter from BotFrameworkAdapter microsoft/botbuilder-js#1763

Merged

stevengum added 2 commits February 21, 2020 14:20

remove EnsureChannelConnectorClientIsCreatedAsync

6222eec

* new test cleanup

make sure scope is not null when calling GetAppCredentialsAsync

c931424

refactor ContinueConversationAsyncWithAudience

53c860b

johnataylor approved these changes Feb 21, 2020

View reviewed changes

libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs Outdated Show resolved Hide resolved

libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs Outdated Show resolved Hide resolved

tomlm added the WIP label Feb 23, 2020

make oAuthScope required, apply PR feedback

21508f3

stevengum marked this pull request as ready for review February 24, 2020 17:56

carlosscastro approved these changes Feb 24, 2020

View reviewed changes

stevengum changed the title ~~[Skills] Add support for proactively messaging non-channel recipients~~ [Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients Feb 24, 2020

stevengum merged commit 5bd7110 into master Feb 24, 2020

stevengum deleted the stgum/audience branch February 24, 2020 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients #3409

[Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients #3409

stevengum commented Feb 19, 2020

coveralls commented Feb 19, 2020 •

edited

fuselabs commented Feb 19, 2020

fuselabs commented Feb 19, 2020

fuselabs commented Feb 21, 2020

fuselabs commented Feb 21, 2020

fuselabs commented Feb 21, 2020

stevengum commented Feb 21, 2020 •

edited

fuselabs commented Feb 21, 2020

[Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients #3409

[Skills] Refactor BFAdapter Auth, Add support for proactively messaging non-channel recipients #3409

Conversation

stevengum commented Feb 19, 2020

coveralls commented Feb 19, 2020 • edited

Pull Request Test Coverage Report for Build 107715

💛 - Coveralls

fuselabs commented Feb 19, 2020

fuselabs commented Feb 19, 2020

fuselabs commented Feb 21, 2020

fuselabs commented Feb 21, 2020

fuselabs commented Feb 21, 2020

stevengum commented Feb 21, 2020 • edited

fuselabs commented Feb 21, 2020

coveralls commented Feb 19, 2020 •

edited

stevengum commented Feb 21, 2020 •

edited