Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TelemetryClient to enable tracking of dialog ('page') views #3440

Merged
merged 14 commits into from Mar 4, 2020

Conversation

garypretty
Copy link
Contributor

@garypretty garypretty commented Feb 25, 2020

Addresses #3441

Update TelemetryClient to enable tracking of page views and add automatic page view logging on dialog start for component / waterfall dialogs.

This PR now adds a new abstract class, LogTelemetryClient, as well as an implementation of it within the ApplicationInsights library, AppInsightsTelemetryClient. All current consumers of the existing BotTelemetryClient have been updated to use the new client, but leaving the existing functionality in place (marked as obselete) for backwards compatibility.

…atic page view logging on dialog start for component / waterfall dialogs.
tomlm
tomlm previously requested changes Feb 25, 2020
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@garypretty garypretty changed the title Update TelemetryClient to enable tracking of dialog ('page') views [DO NOT MERGE] Update TelemetryClient to enable tracking of dialog ('page') views Feb 27, 2020
@garypretty
Copy link
Contributor Author

Agreed with @christopheranderson that, providing we go ahead with this approach, we will not obselete the existing telemetry bits until R9 - this will allow us to run the two side by side until all of our messaging etc is up to date and also to provide us with a chance to ensure that the new bits meet the demands of adaptive too.

This also presents the possibility of us deferring the JS and other repo updates to R9 as well if we don't get through them all next week.

@Danieladu Danieladu mentioned this pull request Feb 29, 2020
@garypretty garypretty changed the title [DO NOT MERGE] Update TelemetryClient to enable tracking of dialog ('page') views Update TelemetryClient to enable tracking of dialog ('page') views Mar 4, 2020
@garypretty
Copy link
Contributor Author

garypretty commented Mar 4, 2020

Update: Due to the fact that if we pursue a non-breaking change then 100% of people who have telemetry enabled within their existing bots will need to make changes to migrate to an updated configuration, coupled with the fact that it is very likely that the number of people to extend the IBotTelemetryClient interface within their own solution is incredibly small - the decision has been taken to extend the interface.
This allows us to allow the vast majority of existing telemetry users to gain the new capabilities without making any changes within their solution. It also does not preclude us from replacing the interface in the future.

cc @cleemullins / @scheyal

@garypretty
Copy link
Contributor Author

Implemented additional interface / extension method to avoid breaking change as discussed with @johnataylor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants