Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null check and code to return default(T) in GetPropertyValueAsync<T> #3448

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Added null check and code to return default(T) in GetPropertyValueAsync<T> #3448

merged 2 commits into from
Feb 27, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Feb 26, 2020

Fixes #3445

@gabog gabog requested a review from tomlm February 26, 2020 18:42
tomlm
tomlm approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 151777b into master Feb 27, 2020
@tomlm tomlm deleted the gabog/StateBug branch February 27, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BotStateSet.GetPropertyValueAsync<T> throws exception when defaultValueFactory returns null in second attempt
2 participants
@gabog @tomlm