Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AdaptiveSkillDialog #3453

Merged
merged 26 commits into from
Mar 6, 2020
Merged

Add AdaptiveSkillDialog #3453

merged 26 commits into from
Mar 6, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Feb 26, 2020 •
edited

Fixes #2324

This PR include the following changes:

  • Adds AdaptiveSkillDialog, schema and ComponentRegistration to the Adaptive package.
  • Updated Microsoft.Bot.Builder.TestBot.Json with code to it can be a Skill consumer and added Sample on how to call SkillEchoBot using AdaptiveSkillDialog.

This is a first pass to AdaptiveSkillDialog, we will add more capabilities as part of R9 and when we start integrating with composer.

FYI: @tomlm, @cwhitten, @luhan2017, @vishwacsena

@tomlm tomlm added the WIP label Feb 28, 2020
@gabog gabog changed the title [DO NOT MERGE] Draft BeginSkillDialog [DRAFT Draft BeginSkillDialog Feb 29, 2020
@gabog gabog changed the title [DRAFT Draft BeginSkillDialog [DRAFT] Draft BeginSkillDialog Feb 29, 2020
@gabog gabog changed the title [DRAFT] Draft BeginSkillDialog Draft AdaptiveSkillDialog Mar 4, 2020
@gabog gabog marked this pull request as ready for review March 4, 2020 01:10
@gabog gabog requested a review from carlosscastro March 4, 2020 01:11
@gabog gabog added Skills and removed Draft PR labels Mar 4, 2020
@gabog gabog changed the title Draft AdaptiveSkillDialog Add AdaptiveSkillDialog Mar 4, 2020
@gabog gabog requested review from vishwacsena and tomlm March 4, 2020 01:48
tomlm
tomlm approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gabog gabog dismissed vishwacsena’s stale review March 6, 2020 21:59

The sdk.schema has been updated as you requested

@gabog gabog merged commit 2ec7fdd into master Mar 6, 2020
@gabog gabog deleted the gabog/BeginSkillDialog branch March 6, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten left review comments

@vishwacsena vishwacsena vishwacsena left review comments

@luhan2017 luhan2017 luhan2017 left review comments

@tomlm tomlm tomlm approved these changes

@carlosscastro carlosscastro carlosscastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Adaptive] Adaptive Skill Dialog in the SDK
6 participants
@gabog @cwhitten @tomlm @vishwacsena @carlosscastro @luhan2017