Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to SkillDialog based on VA feedback. #3458

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Feb 27, 2020

Relates to #3311
Updated samples to work with new changes, cleaned up namespace and added Error Handling code based on skill samples.

FYI: @axelsrz, @stevengum, @clearab, @johnataylor

Updated samples to work with new changes, cleaned up namespace and added Error Handling code based on skill samples.
Added fix for BotState bug.
@gabog gabog requested a review from lzc850612 February 27, 2020 17:44
@gabog gabog requested review from Areax, adrianstevens, stevengum and axelsrz and removed request for Areax and adrianstevens February 27, 2020 18:44
Copy link
Contributor

@lzc850612 lzc850612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gabog gabog merged commit 1481157 into master Feb 27, 2020
@gabog gabog deleted the gabog/SkillDialogUpdatesForVA branch February 27, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants