Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from union to interface/implements in component schema #3468

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Switch from union to interface/implements in component schema #3468

merged 2 commits into from
Mar 2, 2020

Conversation

chrimc62
Copy link
Contributor

This fixes #3459 by changing $role: union to $role: interface and $role: union(kind) to $role: implements(kind) to make the meaning clearer.

@chrimc62 chrimc62 added adaptive R8 Release 8 - March 16th, 2020 labels Feb 29, 2020
@chrimc62 chrimc62 requested a review from tomlm February 29, 2020 00:44
@chrimc62 chrimc62 added this to In Progress in Adaptive via automation Feb 29, 2020
tomlm
tomlm approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit e95b01b into master Mar 2, 2020
Adaptive automation moved this from In Progress to Complete Mar 2, 2020
@tomlm tomlm deleted the chrimc/union branch March 2, 2020 19:25
This was referenced Mar 2, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

Assignees
No one assigned
Labels
R8 Release 8 - March 16th, 2020
Projects
No open projects
Adaptive
Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename $role union/union(type) to interface/interface(type)
2 participants
@chrimc62 @tomlm