Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get member changes for Teams #3473

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

clearab
Copy link
Contributor

@clearab clearab commented Mar 2, 2020

Adding roster change with no alterations to the IConversations interface. Calling getMember would require a downcast from an object of type IConversations. See line 78 of TeamsInfo.cs for an example of what this looks like.

This PR includes:

  • Adding support for the get single member endpoint to the Conversations object
  • Adding support for get single member endpoint to the TeamsInfo object
  • Adding support for getting paged members to the TeamsInfo object

Also fixed the formatting in ConversationsExtensions, because reasons.

Resolves #3447

…ace. Calling getMember would require a downcast from an object of type IConversations. See line 78 of TeamsInfo.cs for an example of what this looks like.
@clearab clearab requested a review from johnataylor March 2, 2020 19:54
@vman
Copy link

vman commented Apr 1, 2020

Hi @clearab, just curious why the GetConversationMemberAsync function wasn't added to the IConversations interface itself instead of requiring a downcast to the Conversations class like you mention?

@clearab
Copy link
Contributor Author

clearab commented Apr 1, 2020

@vman We couldn't add it to IConversations because of our strict backwards-compatibility requirements (it would break anyone who was implementing the interface). We talked about quite a few different options for where this should live and settled on this as the least disruptive and most discoverable option. I'd love any feedback on the implementation choice!

@cleemullins cleemullins deleted the anclear/get-member-changes branch April 6, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support single member & paged members endpoint for Teams
3 participants