Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI build to get coveralls token from key vault #3514

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Set up CI build to get coveralls token from key vault #3514

merged 3 commits into from
Mar 9, 2020

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Mar 6, 2020 •
edited

This renames the var to fit the key vault secret's name.

@BruceHaley BruceHaley changed the title Move CI buildcoveralls upload token in key vault Set up CI build to get coveralls upload token from key vault Mar 6, 2020
@BruceHaley BruceHaley changed the title Set up CI build to get coveralls upload token from key vault Set up CI build to get coveralls token from key vault Mar 6, 2020
tomlm
tomlm approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm added the no parity label Mar 9, 2020
@BruceHaley BruceHaley merged commit e87af31 into master Mar 9, 2020
@BruceHaley BruceHaley deleted the v-bruhal/coverallsfix3-6 branch March 9, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@cleemullins cleemullins Awaiting requested review from cleemullins

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BruceHaley @tomlm