Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable warnings for SkillConversationIdFactoryBase methods in tests #3518

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Disable warnings for SkillConversationIdFactoryBase methods in tests #3518

merged 2 commits into from
Mar 7, 2020

Conversation

EricDahlvang
Copy link
Member

No description provided.

@EricDahlvang EricDahlvang requested a review from gabog March 7, 2020 20:23
gabog
gabog approved these changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@gabog gabog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, add a comment describing why the pragma was added in each instance so people know why is that there.

@EricDahlvang
Copy link
Member Author

Added comments. Thanks Gabo.

@EricDahlvang EricDahlvang merged commit ec7d10a into master Mar 7, 2020
@EricDahlvang EricDahlvang deleted the eric/fixDeprecatedBuildWarnings branch March 7, 2020 23:19
This was referenced Mar 7, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricDahlvang @gabog