Add unit test for CancelAllDialogs and fix eventName and eventValue null #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlm
added
adaptive
bug
cleemullins
suggested changes
Mar 11, 2020
| @@ -47,7 +47,7 @@ public class Recognizer | |||
| /// <param name="telemetryProperties">Additional properties to be logged to telemetry with the LuisResult event.</param> | |||
| /// <param name="telemetryMetrics">Additional metrics to be logged to telemetry with the LuisResult event.</param> | |||
| /// <returns>Analysis of utterance.</returns> | |||
| public virtual async Task<RecognizerResult> RecognizeAsync(DialogContext dialogContext, Activity activity, CancellationToken cancellationToken = default, Dictionary<string, string> telemetryProperties = null, Dictionary<string, double> telemetryMetrics = null) | |||
| public virtual Task<RecognizerResult> RecognizeAsync(DialogContext dialogContext, Activity activity, CancellationToken cancellationToken = default, Dictionary<string, string> telemetryProperties = null, Dictionary<string, double> telemetryMetrics = null) | |||
There was a problem hiding this comment.
I don't understand this, and it seems like an odd one. Can you elaborate?
cleemullins
approved these changes
Mar 11, 2020
This was referenced Mar 11, 2020
tomlm
pushed a commit
that referenced
this pull request
Mar 11, 2020
garypretty
added a commit
that referenced
this pull request
Apr 16, 2020
* Fix AdaptiveTesting to have correct preview labels * Proactive auth: trust incoming token url conditionally (#3533) * Add unit test for CancelAllDialogs and fix eventName and eventValue could be null (#3536) * fix lack of a generic typed method for posting activities to skills (#3539) (#3542) * fix lack of a generic typed method for posting activities to skills * remove duplicated code Co-authored-by: Swagat Mishra <swagatm@microsoft.com> Co-authored-by: swagat mishra <swagatmishra2007@gmail.com> Co-authored-by: Swagat Mishra <swagatm@microsoft.com> * EoC should only be handled when coming from parent in RunAsync (#3540) (#3543) * Added check to only cancel dialogs in RunAsync when EoC comes from a parent bot (root or skill). * Applied URI prefix to caller ID as per OBI spec https://github.com/microsoft/botframework-obi/blob/master/protocols/botframework-activity/botframework-activity.md#bot-calling-skill (cherry picked from commit 3730963) * Merge pull request #3564 from microsoft/tedlee/fix-oauth-credentials (#3571) [OAuth]do not set signInLink to empty when OAuthAppCredentials is set * Address QnAMaker / recognizer telemetry across dialogs / adaptive * Fixes following merge from master * Added comments to the TrackRecognizerResult method on the Recognizer class. * More comments. Co-authored-by: Tom Laird-McConnell <tomlm@microsoft.com> Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com> Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com> Co-authored-by: swagat mishra <swagatmishra2007@gmail.com> Co-authored-by: Swagat Mishra <swagatm@microsoft.com> Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3534
Fixes CancelAllDialogs.eventName and eventValue is valid to be null