Fix path resolver not working when alias in middle #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danieladu
approved these changes
Mar 12, 2020
boydc2014
changed the title
|
Would take this for R9. Workaround is to not use path resolves in dynamic path. |
vishwacsena
added
R9
Thanks, there are two ways to work around,
|
This was referenced Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3545 .
Our property assignment action, SetProperty, SetProperties, and EditArray are not working when the property contains dynamic values to evaluate, and the dynamic value is reference using a shortcut, for example
user[$mylist].todo // not working
user[dialog.mylist].todo // working
The root cause is our path resolver assuming alias (#, $) assume this alias at beginning, and do a full replace at the beginning, which cause broken path if alias is in middle.
The tranforming behavior is broken
user[$mylist].todo => dialog.mylist].todo// user[ is droppedturn.recongized["$instance"] => dialog.instance"]// what's before $ is totally droppedthe fix is to enforce the transform only deals the alias at beginning.