-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update expression escape #3580
Merged
Merged
update expression escape #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
reviewed
Mar 20, 2020
should we throw error when the escape is not valid? if user want |
Actually not, we should not throw, because user will not aware of this error until runtime, we should tolerant that. So your implementation make sense |
boydc2014
approved these changes
Mar 20, 2020
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #3510
update Expression escape policy to make expression achieve higher robustness.
the new strategy of expression evaluation about escape characters is as below:
\n
,\r
,\t
,\\
would be unescaped.\"
would be unescaped. There is no need to escape`
and'
in double quotation mark string\'
would be unescaped. There is no need to escape`
and"
in single quotation mark string\`
and\$
would be unescaped\
prefix, would leave it as issamples: