Add Push/Pop services to TurnContextStateCollection. #3594
Conversation
…ension method * Move DialogStateManager/ScopesPathResolvers into Dialogs assembly * Make all IMemory implementations evaluate ExpressionProperties * Fix layering between expressions and dialogs via MemoryFactory.Create() and internal ducktyping memory * Move ComponentRegistration into Builder assembly * Fix path CAPS names in paths: NOTE I have marked old values as [Obsolete] We should remove these obsolete properties right before we release or we will get broken builds for every PR because of backward compat issues.
Add unit tests for TurnContextStateCollection Add tracing to NullDialogDebugger, cause it's super damn useful and I needed it to debug the unit tests. Fix DialogExpression which wasn't evaluating the dialog.id (messing up debugger output and id's)
| return this.Value.Id; | ||
| } | ||
|
|
||
| return base.ToString(); |
There was a problem hiding this comment.
. [](start = 23, length = 1)
This was mucking up Id calculation, was ending up with id's == type name instead of dialog id. #ByDesign
| namespace Microsoft.Bot.Builder.Tests | ||
| { | ||
| [TestClass] | ||
| public class TurnContextStateCollectionTests |
There was a problem hiding this comment.
TurnContextStateCollectionTests [](start = 17, length = 31)
there were no unit tests for TurnContextStateCollection
#ByDesign
| if (result.Status == DialogTurnStatus.Empty && GetUniqueInstanceId(actionContext) == instanceId) | ||
| { | ||
| // Call begin dialog on our next step, passing the effective options we computed | ||
| var nextAction = actionContext.Actions.First(); |
There was a problem hiding this comment.
can you guarantee that there is an action in the Actions collection here? #ByDesign
There was a problem hiding this comment.
| while (parent != null) | ||
| { | ||
| var ac = parent as ActionContext; | ||
| if (ac != null && ac.Changes != null && ac.Changes.Count > 0) |
There was a problem hiding this comment.
I prefer ac.Changes.Any() instead of ac.Changes.Count > 0 but not a big deal, up to you
| @@ -67,5 +67,15 @@ public override void SetValue(object value) | |||
|
|
|||
| base.SetValue(value); | |||
| } | |||
|
|
|||
| public new string ToString() | |||
There was a problem hiding this comment.
Why is the base base class, ExpressionProperty using public new string ToString() instead of override? Wouldn't it be healthier to use override in ExpressionProperty and here?
| @@ -1,4 +1,5 @@ | |||
| using System.Threading; | |||
| using System.Diagnostics; | |||
#3577