Replace interfaces with Abstract base classes #3602
Conversation
* Cleanup .schema files to not be interface names (aka Microsoft.Dialog instead of Microsoft.IDialog) * make sure schema names are consistent and in correct places.
| @@ -23,7 +23,7 @@ | |||
| "default": "dialog.result" | |||
| }, | |||
| "recognizer": { | |||
| "$kind": "Microsoft.Recognizer", | |||
| "$kind": "Microsoft.IRecognizer", | |||
| "title": "Recognizer", | |||
There was a problem hiding this comment.
Should not have been renamed.
There was a problem hiding this comment.
Looks like you decided to keep the IX in the schema name to correspond to ABC X.
In reply to: 395802524 [](ancestors = 395802524)
| @@ -42,7 +42,7 @@ | |||
| "description": "List of triggers defined for this dialog.", | |||
| "title": "Triggers", | |||
| "items": { | |||
| "$kind": "Microsoft.ITriggerCondition" | |||
| "$kind": "Microsoft.ITrigger" | |||
There was a problem hiding this comment.
$kind": "Microsoft.ITrigger" [](start = 17, length = 28)
Shouldn't this just be Microsoft.Trigger? #Resolved
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/microsoft/botbuilder-dotnet/master/schemas/component.schema", | |||
| "title": "Microsoft ActivityTemplates", | |||
| "description": "Components which are IActivityTemplates", | |||
| "description": "Components which are ActivityTemplate", | |||
There was a problem hiding this comment.
Components which are ActivityTemplat [](start = 20, length = 36)
ActivityTemplate components would be clearer.
| "title": "Microsoft ILanguageGenerator", | ||
| "description": "Union of components which implement the ILanguageGenerator interface", | ||
| "title": "Microsoft LanguageGenerator", | ||
| "description": "Components which dervie from the LanguageGenerator class", |
There was a problem hiding this comment.
dervie [](start = 37, length = 6)
spelling
| @@ -1,7 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Did you decide to keep the schema names as IX when they are interfaces in the schema?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/microsoft/botbuilder-dotnet/master/schemas/component.schema", | |||
| "$role": "implements(Microsoft.EntityRecognizers)", | |||
| "$role": "implements(Microsoft.IEntityRecognizer)", | |||
| "title": "Currency Entity Recognizer", | |||
| "description": "Recognizer which recognizes currency.", | |||
There was a problem hiding this comment.
"Recognizer which recognizes currency.", [](start = 19, length = 40)
"Currency recognizer" and we are inconsistent about period or not.
There was a problem hiding this comment.
I would rename all of these, "Recognizer which recognizes X" is just wordy and hides the most important part, i.e. X.
In reply to: 395805747 [](ancestors = 395805747)
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/microsoft/botbuilder-dotnet/master/schemas/component.schema", | |||
| "$role": "implements(Microsoft.EntityRecognizers)", | |||
| "$role": "implements(Microsoft.IEntityRecognizer)", | |||
| "title": "Mentions Entity Recognizer", | |||
| "description": "Recognizer which recognizes @Mentions", | |||
There was a problem hiding this comment.
Mentions [](start = 49, length = 8)
No period.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/microsoft/botbuilder-dotnet/master/schemas/component.schema", | |||
| "$role": "implements(Microsoft.ITriggerCondition)", | |||
| "$role": "implements(Microsoft.ITrigger)", | |||
| "title": "On cancel dialog", | |||
| "description": "Actions to perform on cancel dialog event.", | |||
There was a problem hiding this comment.
Actions to perform on cancel dialog event. [](start = 20, length = 42)
On cancel event actions
| @@ -791,148 +791,8 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "Microsoft.SkillDialog": { | |||
There was a problem hiding this comment.
SkillDialog [](start = 19, length = 11)
Was this deleted?
| "title": "Microsoft.SkillDialog", | ||
| "description": "Begin a remote skill dialog.", | ||
| "$ref": "#/definitions/Microsoft.SkillDialog" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Why is this in here and not sdk.schema?
#3178
NOTE: I keep the IXXX nomenclature for defining the union types in the .schema file