Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IMemory interface and tryEvaluate for expression #3635

Merged
merged 24 commits into from
Mar 31, 2020
Merged

Update IMemory interface and tryEvaluate for expression #3635

merged 24 commits into from
Mar 31, 2020

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Mar 27, 2020 •
edited

Add an optional parameter options in tryEvaluate.

Add an optional parameter allowInsubstitution in getValue method of IMemory.

In any boolean context, use raw value, in any other context, use substituted value.

Fix part of #3625

Will do a follow up for LG strict mode improvement.

tomlm
tomlm previously requested changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

chrimc62
chrimc62 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

chrimc62
chrimc62 suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@boydc2014
Copy link
Contributor Author

Thanks @chrimc62 for great comments, all resolved.

chrimc62
chrimc62 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few minor issues, but looking good.

libraries/AdaptiveExpressions/ExpressionFunctions.cs Outdated Show resolved Hide resolved
libraries/AdaptiveExpressions/ExpressionFunctions.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Microsoft.Bot.Builder.Dialogs.Adaptive.csproj Outdated Show resolved Hide resolved
@boydc2014 boydc2014 merged commit 0a7bb4f into master Mar 31, 2020
@boydc2014 boydc2014 deleted the donglei/expresion-evalOptions branch March 31, 2020 07:56
This was referenced Mar 31, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@tomlm tomlm tomlm left review comments

@Danieladu Danieladu Awaiting requested review from Danieladu

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boydc2014 @chrimc62 @tomlm @vishwacsena