-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix foreach issue and update some schema examples #3704
Conversation
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Schemas/Actions/Microsoft.Foreach.schema
Show resolved
Hide resolved
@vishwacsena, I did want to add ForeachPage, but I found that the Nested ForeachPage is not working as expected. Here is a test case I created:
But in fact, it didn't run the second iteration of the outer ForeachPage. the actually result missed the three steps.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luhan2017 were you able to get past the issues with ForEachPage? |
@vishwacsena , I have figured out why the foreachPage nested not working. it can be resolved by resetting the PageIndex in the BeginDialog. I've update the ForeachPage with schema and test cases. |
Fixes #3680 and #3700