Replace null check with string.IsNullOrWhiteSpace() #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrivera-ms
requested review from
cleemullins,
aarongas and
gabog
and removed request for
aarongas
There was a problem hiding this comment.
Thanks @mrivera-ms! Note that there are not super well-defined semantics of null vs empty credentials. To be safe on this change, we'd need to test basic bot scenarios using 1) valid app + password and 2) no credentials locally with emulator. If you have tested those 2, I'm ready to sign off.
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3590, by returning MicrosoftAppCredentials.Empty when AppId is set to null or empty spaces.