Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Edit /// comments. Fix some code smell. #3718

Merged
merged 5 commits into from
Apr 15, 2020
Merged

Add/Edit /// comments. Fix some code smell. #3718

merged 5 commits into from
Apr 15, 2020

Conversation

JonathanFingold
Copy link
Contributor

@JonathanFingold JonathanFingold commented Apr 9, 2020 •
edited

Can QnAMakerDialog2 be renamed to something more meaningful, perhaps AdaptiveQnaMakerDialog?

@JonathanFingold JonathanFingold mentioned this pull request Apr 9, 2020
Closed
tomlm
tomlm suggested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@JonathanFingold JonathanFingold mentioned this pull request Apr 10, 2020
Closed
@vipeketi
Copy link
Contributor

remove obsolete metadataBoost from QnA Maker queries #3723

vipeketi
vipeketi previously requested changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@vipeketi vipeketi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove obsolete metadataBoost from QnA Maker queries #3723

@JonathanFingold
Copy link
Contributor Author

remove obsolete metadataBoost from QnA Maker queries #3723

@vipeketi , This PR fixes a documentation issue. The work to remove the MetadataBoost property is more involved an touches multiple other classes and tests and should be done in a separate PR.

tomlm
tomlm approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrivera-ms mrivera-ms dismissed vipeketi’s stale review April 15, 2020 19:39

Reviewed by development team. Does not apply to this change.

@mrivera-ms mrivera-ms merged commit d14782b into master Apr 15, 2020
This was referenced Apr 15, 2020
Closed
Closed
@mrivera-ms mrivera-ms deleted the jf/AdaptiveQnAMakerDialog branch April 15, 2020 19:39
@tomlm tomlm mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@vipeketi vipeketi Awaiting requested review from vipeketi

Assignees

@cleemullins cleemullins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JonathanFingold @vipeketi @tomlm @cleemullins @vishwacsena @mrivera-ms