Updated RunAsync to avoid sending EoC from the RootBot to the channel #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…killBot and test Parent -> Skill 1 -> Skill 2. Updated code in general to align with samples (WIP).
Added temp workaround for OAuthPrompt for skills.
WIP: * Update SkillHandler to store SkillConversationReference in state. * Refactored DialogExtensions and created tests for it
Fixed issue in DialogSkillBot calling EchoSkill
gabog
requested review from
johnataylor,
EricDahlvang,
stevengum,
tracyboehrer,
axelsrz and
Adjective-Object
tracyboehrer
approved these changes
Apr 14, 2020
johnataylor
approved these changes
Apr 15, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3699.
In this PR I refactored DialogExtensions to properly handle end of conversation in different scenarios and added unit tests for it.
@stevengum, @tracyboehrer, @axelsrz: The changes in DialogExtensions, DialogExtensionsTests and SkillHandler need to be ported to JS and Python.
As part of this PR, I also updated the DialogToDialog examples to align with the simpler version in Samples so we can manually test and debug the test scenarios (these examples are optional and don't need to be ported or reviewed).
Note: the branch name is not very descriptive but this PR is mainly about RunAsync fixes.