Move QnAMaker Dialog/Recognizer out of Adaptive and into QnA assembly #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move QnAMakerDialog and QnAMakerRecognizer into QnA assembly * Move schema definitions int QnA assembly * Move ComponentRegistration into QnA Assembly * remove dependencies between Adaptive and QnA * NOTE: Needed to move ITemplate<> into a shared location as that was only dependency on Adaptive, so moved it into BotBuilder which is where IRecognizer lives.
tomlm
requested review from
boydc2014,
carlosscastro,
chrimc62,
cleemullins,
gabog,
johnataylor and
mrivera-ms
as code owners
cleemullins
approved these changes
Apr 21, 2020
| @@ -0,0 +1,258 @@ | |||
| //using System.Collections.Generic; | |||
There was a problem hiding this comment.
I don't think this is right.
There was a problem hiding this comment.
|
|
||
| // Recognizers | ||
| yield return new DeclarativeType<QnAMakerRecognizer>(QnAMakerRecognizer.Kind); | ||
|
|
||
| // Triggers | ||
| yield return new DeclarativeType<OnQnAMatch>(OnQnAMatch.Kind); | ||
| // yield return new DeclarativeType<OnQnAMatch>(OnQnAMatch.Kind); |
There was a problem hiding this comment.
Do we need this comment.
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3719