add allowloop to repeat dialog and test #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieofxie
requested review from
cleemullins,
mrivera-ms and
tomlm
as code owners
tomlm
reviewed
Apr 24, 2020
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/RepeatDialog.cs
Show resolved
Hide resolved
tomlm
added
changes required
luhan2017
removed
the
changes required
|
OK, it seems tests passed but no result for coverage.. |
tomlm
reviewed
Apr 29, 2020
| @@ -58,10 +70,16 @@ public override async Task<DialogTurnResult> BeginDialogAsync(DialogContext dc, | |||
| var repeatedIds = dc.State.GetValue<List<string>>(TurnPath.RepeatedIds, () => new List<string>()); | |||
| if (repeatedIds.Contains(targetDialogId)) | |||
| { | |||
| throw new ArgumentException($"Recursive loop detected, {targetDialogId} cannot be repeated twice in one turn."); | |||
| if (this.AllowLoop == null || this.AllowLoop.GetValue(dc.State) == false) | |||
| { | |||
There was a problem hiding this comment.
I would move this conidtion around the entire repeatedIds section, no need to track ids if you aren't using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3742