Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QnAMaker] Volitile LowScoreVariation and Active Learning Issue fix #3786

Merged
merged 4 commits into from
Apr 29, 2020
Merged

[QnAMaker] Volitile LowScoreVariation and Active Learning Issue fix #3786

merged 4 commits into from
Apr 29, 2020

Conversation

vipeketi
Copy link
Contributor

For issue #3714

@vipeketi vipeketi mentioned this pull request Apr 22, 2020
Closed
@vipeketi
Copy link
Contributor Author

@johnataylor @mrivera-ms please review.

tomlm
tomlm approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

cleemullins
cleemullins suggested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it's a code change w/o any corresponding Unit Test change.

Please add test coverage for this change.

@tomlm tomlm added the changes required Reviews has requested changes to be made before approval label Apr 24, 2020
@vipeketi
Copy link
Contributor Author

This looks good, but it's a code change w/o any corresponding Unit Test change.

Please add test coverage for this change.

Enhanced existing test for coverage.

@cleemullins cleemullins merged commit 8148e9a into master Apr 29, 2020
@cleemullins cleemullins deleted the vipeketi/volitilegetlowscore branch April 29, 2020 20:00
This was referenced Apr 29, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@tomlm tomlm tomlm approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
changes required Reviews has requested changes to be made before approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vipeketi @cleemullins @tomlm