[PORT] Bot Change Detection #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2020 11:23
Add dialog.GetVersion() Add DialogSet.GetVersion() Add DialogContainer.GetInternalVersion() Add DialogContainer.CheckForVersionChange() Implement AdaptiveDialog.GetInternalVersion() to detect triggers, schema as well as dialog changes Unit tests, etc.
tomlm
requested review from
cleemullins,
gabog,
johnataylor and
mrivera-ms
as code owners
tomlm
changed the title
cleemullins
reviewed
Apr 24, 2020
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveDialog.cs
Outdated
Show resolved
Hide resolved
Stevenic
reviewed
Apr 25, 2020
| /// GetInternalVersion - Returns internal version identifier for this container. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// DialogContainers detect changes of all sub-components in the container and map that to an DialogChanged event. |
There was a problem hiding this comment.
DialogChanged [](start = 102, length = 13)
Should be: VersionChanged
Stevenic
reviewed
Apr 25, 2020
| @@ -5,10 +5,34 @@ namespace Microsoft.Bot.Builder.Dialogs | |||
| { | |||
| public class DialogEvents | |||
| { | |||
| /// <summary> | |||
| /// Event fired when a dialog beginDialog() is called. | |||
There was a problem hiding this comment.
beginDialog [](start = 38, length = 11)
Should be: BeginDialogAsync()
cleemullins
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
I've got no usefull feedback to add. LGTM with @Stevenic signed off
| sb.Append(trigger.GetExpression().ToString()); | ||
| } | ||
|
|
||
| return Convert.ToBase64String(SHA256.Create().ComputeHash(Encoding.UTF8.GetBytes(sb.ToString()))); |
There was a problem hiding this comment.
This line is in several places. Worth moving to a shared static somewhere?
This was referenced Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DialogContainer.CheckForVersionChange() - which is called on BeginDialog/ContinueDialog/ResumeDialog() to detect that a dialogContainer has changed
Unit tests, etc.