Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSO with skill dialog and expected replies #3818

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Support SSO with skill dialog and expected replies #3818

merged 5 commits into from
Apr 28, 2020

Conversation

swagatmishra2007
Copy link
Member

Support SSO with skill dialog and expected replies

stevengum
stevengum previously requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some refactoring to do here, perhaps we should schedule something offline to talk it out with the required parties

libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Show resolved Hide resolved
libraries/Microsoft.Bot.Builder/Adapters/TestAdapter.cs Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs Show resolved Hide resolved
@stevengum stevengum mentioned this pull request Apr 28, 2020
Merged
@gabog gabog dismissed stale reviews from stevengum and carlosscastro April 28, 2020 22:19

Feedback addressed

@cleemullins cleemullins merged commit 460174f into master Apr 28, 2020
@cleemullins cleemullins deleted the swagatm/ssoskills branch April 28, 2020 22:32
@tomlm tomlm mentioned this pull request Apr 28, 2020
Closed
This was referenced Apr 28, 2020
Closed
Closed
This was referenced Apr 29, 2020
Closed
Closed
Closed
Merged
@gabog gabog mentioned this pull request Apr 29, 2020
Closed
6 tasks
@swagatmishra2007 swagatmishra2007 mentioned this pull request Apr 29, 2020
Closed
@tracyboehrer tracyboehrer mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@cleemullins cleemullins cleemullins approved these changes

@gabog gabog gabog approved these changes

@carlosscastro carlosscastro carlosscastro left review comments

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swagatmishra2007 @cleemullins @gabog @stevengum @carlosscastro