Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null on Activity.From when logging telemetry #3819

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Check for null on Activity.From when logging telemetry #3819

merged 1 commit into from
Apr 29, 2020

Conversation

garypretty
Copy link
Contributor

Fixes #3814 - null reference exception when logging telemetry and [From] property is null.

@garypretty garypretty self-assigned this Apr 28, 2020
tomlm
tomlm approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit 6fbd49c into master Apr 29, 2020
@tomlm tomlm deleted the gary/qna-nre branch April 29, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlm tomlm tomlm approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

Assignees

@garypretty garypretty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null [From] on [Activity] Results in NRE during call to QnaMaker.GetAnswersRawAsync
2 participants
@garypretty @tomlm