Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkillDialog activity type handling updates #3834

Merged
merged 5 commits into from
Apr 30, 2020
Merged

SkillDialog activity type handling updates #3834

merged 5 commits into from
Apr 30, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Apr 29, 2020 •
edited

Fixes #3833

  • Removed restriction for message and event types from SkillDialog.
  • Added special handling for Invoke Activities in SkillDIalog.
  • Added virtual protected method to allow users to validate continue dialog operations and reject activities that are not allowed.
  • Updated BotFrameworkAdapter to evaluate ExpectReplies before Invoke activities to support SkillDialog.
  • Refactored some SSO code in SkillDIalog to make it a bit simpler.
  • Updated tests.
  • Added IsSuccessStatusCode helper to InvokeResponse to simplify checking for valid status (inspired by dotnet's HttpResponseMessage.IsSuccessStatusCode)

@gabog
Removed restriction for message and event types from SkillDialog.
edf1b2e 
Added special handling for Invoke Activities in SkillDIalog.
Added virtual protected methods to allow users to validate begin and continue dialog opertaions and reject activities that are not allowed.
Updated BotFrameworkAdapter to evaluate ExpectReplies before Invoke activities to support SkillDialog.
Refactored some SSO code in SkillDIalog to make it a bit simpler.
Updated tests.
Added IsSuccessStatusCode helper to InvokeResponse to simplify checking for valid status (inspired by dotnet's HttpResponseMessage.IsSuccessStatusCode)
@gabog gabog requested review from tomlm and Stevenic April 29, 2020 17:48
@gabog gabog added the Skills label Apr 29, 2020
@tomlm tomlm added the Draft PR label Apr 29, 2020
@gabog gabog marked this pull request as ready for review April 30, 2020 01:24
@tomlm tomlm removed the Draft PR label Apr 30, 2020
tomlm
tomlm approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins cleemullins merged commit 2ea5614 into master Apr 30, 2020
@cleemullins cleemullins deleted the gabog/SkillDialogUpdates branch April 30, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@tomlm tomlm tomlm approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SkillDialog to handle all activity types
3 participants
@gabog @cleemullins @tomlm