added debug signature to recognizers #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
suggested changes
May 1, 2020
carlosscastro
approved these changes
May 4, 2020
|
Approved from an adaptive point of view. @cleemullins In terms of tests, the debugging classes are satellite classes and Tom is adding one more class to which the debugging is satellite to (there are already many). both the recognizers and the debug support have tests separately, so I'm not too concerned about this. If you feel we still need something specific here feel free to discuss with Tom, just chiming in and setting some context. |
cleemullins
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3557
recognizers were not capturing file location when instantiated via code, updated constructors to do appropriate goo.