Fix signature of LanguageGenerator base class #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2020 15:12
* removed unneeded serialize/unserialize with this change LG can return an object or a string.
tomlm
requested review from
cleemullins,
gabog,
johnataylor and
mrivera-ms
as code owners
cleemullins
approved these changes
May 2, 2020
carlosscastro
approved these changes
May 4, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3558
LG returns an object when binding to herocards/activity.
object was being serialized to JSON, then run through code to detect if it's JSON and convert it to an object.
This was all because LanguageGenerator.Generate() had signature of string for the return type.
Changes