Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WaterfallStepContext to use parent dc properly #3855

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix WaterfallStepContext to use parent dc properly #3855

merged 1 commit into from
May 2, 2020

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented May 2, 2020

fixes #3854

  • cleaned up CreateInnerDC so it is applied consistently
  • changed WaterfallStepContext ctor to pass in parent dc.

* cleaned up CreateInnerDC so it is applied consistently
27f7c48 
* changed WaterfallStepContext ctor to pass in parent dc.
@tomlm tomlm requested review from Stevenic and vishwacsena May 2, 2020 15:48
Stevenic
Stevenic approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm merged commit a4e3b3e into master May 2, 2020
@tomlm tomlm deleted the tomlm/fixWaterfallDcParent branch May 2, 2020 17:36
This was referenced May 2, 2020
Closed
Closed
Closed
@EricDahlvang EricDahlvang mentioned this pull request Aug 19, 2020
Merged
@stevengum stevengum mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@boydc2014 boydc2014 boydc2014 approved these changes

@gabog gabog Awaiting requested review from gabog

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Adaptive] Declarative adaptive dialogs (composer dialogs) do not work with non adaptive dialogs
3 participants
@tomlm @Stevenic @boydc2014