Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkillDialogUpdates for ConnectionName. #3866

Merged
merged 5 commits into from
May 5, 2020
Merged

SkillDialogUpdates for ConnectionName. #3866

merged 5 commits into from
May 5, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented May 4, 2020

Moved OAuth ConnectionName from BeginSkillDialogOptions to SkillDialogOptions.
Updated AdaptiveSkillDIalog to expose a connectionName and use it.
Updated tests and schema.

gabog added 2 commits May 4, 2020 19:26
@gabog
Moved OAuth ConnectionName from BeginSkillDialogOptions to SkillDialo…
a5748ed 
…gOptions.

Updated AdaptiveSkillDIalog to expose a connectionName and use it.
Updated tests and schema.
@gabog
Added default value.
8bda425
@gabog gabog marked this pull request as ready for review May 4, 2020 23:43
@gabog gabog requested review from stevengum and Stevenic May 4, 2020 23:43
@gabog gabog added no parity R9 Release 9 - May 15th, 2020 labels May 4, 2020
stevengum
stevengum suggested changes May 5, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small optimization in SkillDialog (we don't need to store the connectionName in the DialogState), but otherwise it looks good.

:shipit:

libraries/Microsoft.Bot.Builder.Dialogs/SkillDialog.cs Outdated Show resolved Hide resolved
stevengum
stevengum approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gabog
Copy link
Contributor Author

gabog commented May 5, 2020

@swagatmishra2007, just as an FYI, when this gets merged you may need to update the sso samples.

@cleemullins cleemullins merged commit 9edeaea into master May 5, 2020
@cleemullins cleemullins deleted the gabog/SkillDialogConnectionNameMove branch May 5, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@cleemullins cleemullins cleemullins approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@tomlm tomlm Awaiting requested review from tomlm

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
R9 Release 9 - May 15th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabog @cleemullins @stevengum