Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ClassName for adapter tests yaml filters #4449

Closed
wants to merge 4 commits into from
Closed

Use ClassName for adapter tests yaml filters #4449

wants to merge 4 commits into from

Conversation

EricDahlvang
Copy link
Member

Fixes #4448

@EricDahlvang EricDahlvang requested review from gabog, mrivera-ms and a team as code owners August 13, 2020 22:49
BruceHaley
BruceHaley approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@BruceHaley BruceHaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some typos. I really like the filtering based on ClassName. Not sure whether that existed before dotnet test.

@EricDahlvang EricDahlvang deleted the eric/adapterFunctionalTestsYaml branch August 14, 2020 01:07
@ceciliaavila ceciliaavila mentioned this pull request May 5, 2023
Closed
tracyboehrer pushed a commit that referenced this pull request May 16, 2023
@sw-joelmut @ceciliaavila
[#6628] port [#4449] CloudAdapter always builds Connector with Micros…
0cda584 
…oftAppCredentials (never CertificateAppCredentials) -- certificate auth flow broken (#6631)

* Add functionality to auth with a certificate

* Add unit tests

* Apply Visual Studio suggestion

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>

* Fix indentation

---------

Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceHaley BruceHaley BruceHaley approved these changes

@mrivera-ms mrivera-ms mrivera-ms approved these changes

@gabog gabog Awaiting requested review from gabog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook and Webex functional tests not running
3 participants
@EricDahlvang @BruceHaley @mrivera-ms