New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add create conversation to CloudAdapter #5562
Conversation
Pull Request Test Coverage Report for Build 251768
💛 - Coveralls |
/// specified users, the ID of the activity's <see cref="IActivity.Conversation"/> | ||
/// will contain the ID of the new conversation.</para> | ||
/// </remarks> | ||
public virtual Task CreateConversationAsync(string botAppId, string channelId, string serviceUrl, ConversationParameters conversationParameters, BotCallbackHandler callback, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason we didn't have this method before? Or any of the CreateConversationAsync implementations in BotFrameworkAdapter
?
Will this support Skills making 1:1 conversations on behalf of the host bot (e.g. in Teams)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevengum I'm not sure about Skills, but this should enable CloudAdapter in this Teams scenario: https://github.com/microsoft/BotBuilder-Samples/blob/main/samples/csharp_dotnetcore/57.teams-conversation-bot/Bots/TeamsConversationBot.cs#L150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was just an omission. This improves the signature slightly. Its probably fair to say we simply don't have enough examples to make strong claims around how general any of this is. It improves the typing (removes the casts) by adding it to the abstract class and makes things more consistent. This works for Teams.
Is this an R14 goal? I only ask because at least for the Teams conversation sample, this would be required to get around my hack (which we could never release). I can't say whether the Composer Teams samples are on the slate for R14, so it may not matter. |
b5be283
to
b1a3ca6
Compare
|
@tracyboehrer yes absolutely R14. Precisely because the gap you identified! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for Teams. However, will this work from a skill without also exposing 'audience'? (as pointed out by @stevengum )
Fixes #5488
Also updates the abstract class to avoid casts in the application code.