Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support object comparison in == #5575

Merged
merged 4 commits into from May 12, 2021
Merged

Support object comparison in == #5575

merged 4 commits into from May 12, 2021

Conversation

Danieladu
Copy link
Collaborator

Fixes #5563

Description

Support object comparison in ==

Specific Changes

  1. Support object comparison in contains
  2. Support object comparison for operator == and !=

@Danieladu Danieladu requested a review from chrimc62 May 11, 2021 06:02
@coveralls
Copy link
Collaborator

coveralls commented May 11, 2021 •
edited

Pull Request Test Coverage Report for Build 244334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 78.782%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/FunctionUtils.cs 17 94.44%
Totals Coverage Status
Change from base Build 244316: -0.007%
Covered Lines: 18149
Relevant Lines: 23037
💛 - Coveralls

chrimc62
chrimc62 approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Danieladu Danieladu marked this pull request as ready for review May 12, 2021 01:19
@Danieladu Danieladu requested review from a team as code owners May 12, 2021 01:19
@Danieladu Danieladu requested a review from luhan2017 May 12, 2021 01:19
@Danieladu Danieladu merged commit 39b7a60 into main May 12, 2021
@Danieladu Danieladu deleted the hond/equal branch May 12, 2021 03:36
This was referenced May 12, 2021
Closed
Closed
Closed
santgr11 added a commit to southworks/botbuilder-dotnet that referenced this pull request May 17, 2021
@santgr11
Revert "Support object comparison in == (microsoft#5575)"
0cecb80 
This reverts commit 39b7a60.
santgr11 added a commit to southworks/botbuilder-dotnet that referenced this pull request May 17, 2021
@santgr11
Revert "Revert "Support object comparison in == (microsoft#5575)""
1d95f4f 
This reverts commit 0cecb80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support object comparison in ==
3 participants
@Danieladu @coveralls @chrimc62