Fix OAuth prompt should store in turn.token, not dialog.token #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Composer docs [issue 121](MicrosoftDocs/composer-docs#121) and related Composer [issue 6767](microsoft/BotFramework-Composer#6767). PS. Does the current example for the `defaultValue` field make any sense (line 87).
BruceHaley
changed the title
Pull Request Test Coverage Report for Build 252749
💛 - Coveralls |
JonathanFingold
approved these changes
Jun 21, 2021
tomlm
approved these changes
Jun 24, 2021
This was referenced Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Also see Jonathan's pr 5660
Description
This fixes the tests covering Jonathan Fingold's patch in the file Microsoft.OAuthInput.schema. He changed "dialog.token" to "turn.token". #minor
Specific Changes
The same change made in tests/Microsoft.Bot.Builder.TestBot.Json/testbot.schema and tests/tests.schema.