[#5676] BotFrameworkAdapter CreateConversationAsync overrides conversationParameters.ChannelData

[MartinLuccanera]

Fixes #5676

Description

This PR updates the CreateConversationAsync method to stop overriding the conversationParameters.ChannelData with the TenantId.

Detailed Changes

• Updated BotFrameworkAdapter class to add the TenantId as a new property in conversationParameters.ChannelData instead of overriding the object.

Testing

These images show a Teams bot failing on the createConversation before the fix and working after applying it.

[johnataylor]

This whole method is basically redundant now right?

We don't seem to use this particular overload in samples 57 or 58 which is presumably why haven't seen this reported.

Anyhow could you also mark the method as obsolete.

[johnataylor]

The method should be marked obsolete now, right?

[ceciliaavila]

The method should be marked obsolete now, right?

Hi @johnataylor, we confirmed that this overload is not being used in the samples and the only difference with the original method is that it uses the conversationReference to set the TenantId in the conversationParameters.
We marked it as obsolete.
Thanks.